Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Hotfix][Config] Fix configuration key sort disorder #7893

Merged
merged 2 commits into from
Oct 25, 2024
Merged

[Hotfix][Config] Fix configuration key sort disorder #7893

merged 2 commits into from
Oct 25, 2024

Conversation

hailin0
Copy link
Member

@hailin0 hailin0 commented Oct 23, 2024

Purpose of this pull request

[Hotfix][Config] Fix configuration key sort disorder

Does this PR introduce any user-facing change?

How was this patch tested?

Check list

@hailin0
Copy link
Member Author

hailin0 commented Oct 23, 2024 •
edited
Loading

link #4268

@github-actions github-actions bot added the core SeaTunnel core module label Oct 23, 2024
hailin0
hailin0 commented Oct 23, 2024
View reviewed changes
seatunnel-config/seatunnel-config-base/pom.xml
@@ -69,11 +69,29 @@
<exclude>com/typesafe/config/ConfigParseOptions.class</exclude>
<exclude>com/typesafe/config/ConfigMergeable.class</exclude>
<exclude>com/typesafe/config/impl/ConfigParser.class</exclude>
<exclude>com/typesafe/config/impl/ConfigParser$1.class</exclude>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Filter inner classes

@hailin0 hailin0 force-pushed the dev-fix-config-sort branch 2 times, most recently from 14942b6 to 4752905 Compare October 23, 2024 12:04
@hailin0
Copy link
Member Author

hailin0 commented Oct 24, 2024

image

@hailin0 hailin0 marked this pull request as ready for review October 24, 2024 17:08
@hailin0 hailin0 merged commit 88be4fd into apache:dev Oct 25, 2024
4 of 5 checks passed
@hailin0 hailin0 mentioned this pull request Oct 28, 2024
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hisoka-X Hisoka-X Hisoka-X approved these changes

@dailai dailai dailai approved these changes

Assignees
No one assigned
Labels
approved core SeaTunnel core module reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hailin0 @dailai @Hisoka-X